refactor: code review cleanup and bug fixes - #350
Merged
Conversation
- Fix import ordering in processor.py - Fix 亿级 bug: 100001000 => 一亿零一千 (was 一亿一千) - Share rule instances in Chinese ITN verbalizer (build time -15%) - Don't create Transliteration when transliterate=False in Japanese TN - Share Whitelist instance in Chinese TN normalizer - Support full-width comma in Measure strip_comma
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code review findings from a full-repo review:
Bug fixes:
100001000→一亿零一千(was一亿一千, missing 零)，in Measure strip_commaPerformance:
transliterate=Falsein Japanese TNCode quality:
Test plan